Issue 72410043: code review 72410043: encoding/xml: fix to allow xml declaration with EncodeToken

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72410043: code review 72410043: encoding/xml: fix to allow xml declaration with EncodeToken (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by jasdel

Modified:
9 years, 9 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

encoding/xml: fix to allow xml declaration with EncodeToken This changes allows the first token encoded to be a xml declaration. A ProcInst with target of xml. Any other ProcInst after that with a target of xml will fail Fixes Issue 7380.

Patch Set 1 #

Patch Set 2 : diff -r 72b4b258b09b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 72b4b258b09b https://code.google.com/p/go/ #

Patch Set 4 : diff -r 72b4b258b09b https://code.google.com/p/go/ #

Patch Set 5 : diff -r 72b4b258b09b https://code.google.com/p/go/ #

Patch Set 6 : diff -r b1e34388854e https://code.google.com/p/go/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -2 lines)			Patch
		src/pkg/encoding/xml/marshal.go	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
		src/pkg/encoding/xml/marshal_test.go	View	1 2 3 4	2 chunks	+35 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jasdel

Hello golang-codereviews@googlegroups.com (cc: rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/

10 years, 1 month ago (2014-03-07 08:13:14 UTC) #1

rsc

LGTM Thank you. I have added an explanation to the doc comment for EncodeToken and ...

9 years, 11 months ago (2014-05-13 03:34:37 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=8a13066e4922 *** encoding/xml: fix to allow xml declaration with EncodeToken This changes ...

9 years, 11 months ago (2014-05-13 03:35:57 UTC) #3

*** Abandoned ***

Expand All Messages | Collapse All Messages