Issue 7235081: code review 7235081: cmd/gc: put 'not used' message on correct line

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7235081: code review 7235081: cmd/gc: put 'not used' message on correct line (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:
dave

CC:
ken2, golang-dev

Visibility:
Public.

cmd/gc: put 'not used' message on correct line Fixes issue 4663.

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+662 lines, -1220 lines)			Patch
M	src/cmd/gc/go.y	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/cmd/gc/y.tab.h	View	1	3 chunks	+21 lines, -25 lines	0 comments	Download
M	src/cmd/gc/y.tab.c	View	1	184 chunks	+608 lines, -1191 lines	0 comments	Download
M	test/fixedbugs/bug357.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug379.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/issue4654.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
A	test/fixedbugs/issue4663.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-02-02 02:13:39 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=96fda8bda97b *** cmd/gc: put 'not used' message on correct line Fixes issue ...

12 years, 1 month ago (2013-02-02 02:13:46 UTC) #2

dave_cheney.net

12 years, 1 month ago (2013-02-02 02:30:20 UTC) #3

Message was sent while issue was closed.

SGTM, even this case works.

lucky(~/src) % go run tc.go 
# command-line-arguments
./tc.go:5: append(s, "") evaluated but not used