code review 7232059: include: Plan 9: move Runemax to arch-dependent files

include: Plan 9: hide any previous definition of Runemax

Runemax is already defined in libc on 64-bit version of
Plan 9, but is not defined on other versions.
To accommodate, we make sure to rename any previous
instance of Runemax and re-define it subsequently.

[akumar, 2013-01-30 14:30:49]

Hello rsc@golang.org, ality@pbrane.org, rminnich@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-01-30 14:45:37]

Sorry, but no. Runemax is not architecture-dependent in any way. You're
using u.h as a proxy for "not used by the Plan 9 build" but that's not what
it means. You can do something like

#define Runemax Plan9Runemax
#include </sys/include/libc.h>
#undef Runemax

Russ

[akumar, 2013-01-30 15:21:46]

PTAL.

Also updated description.

[rsc, 2013-01-30 15:47:17]

LGTM

[rsc, 2013-01-30 15:56:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=449c3ca9f5c3 ***

include: Plan 9: hide any previous definition of Runemax

Runemax is already defined in libc on 64-bit version of
Plan 9, but is not defined on other versions.
To accommodate, we make sure to rename any previous
instance of Runemax and re-define it subsequently.

R=rsc, ality, rminnich
CC=golang-dev
https://codereview.appspot.com/7232059

Committer: Russ Cox <rsc@golang.org>

[lucio, 2013-01-30 16:12:31]

It's unfortunate that the two Plan 9 architectures disagree, what
happens in the ARM case?

Lucio.

On 1/30/13, Russ Cox <rsc@golang.org> wrote:
> Sorry, but no. Runemax is not architecture-dependent in any way. You're
> using u.h as a proxy for "not used by the Plan 9 build" but that's not what
> it means. You can do something like
>
> #define Runemax Plan9Runemax
> #include </sys/include/libc.h>
> #undef Runemax
>
> Russ
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>