Issue 7229050: code review 7229050: net: fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7229050: code review 7229050: net: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by iant

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Patch Set 2 : diff -r 1b4f2eb45509 https://code.google.com/p/go #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	src/pkg/net/sock_windows.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 2 months ago (2013-01-28 17:20:23 UTC) #1

minux1

LGTM modulo the comment below. Tested on windows/386, at least net and net/http tests are ...

12 years, 2 months ago (2013-01-28 17:30:16 UTC) #2

iant

Thanks. https://codereview.appspot.com/7229050/diff/1/src/pkg/net/sock_windows.go File src/pkg/net/sock_windows.go (right): https://codereview.appspot.com/7229050/diff/1/src/pkg/net/sock_windows.go#newcode45 src/pkg/net/sock_windows.go:45: func sysSocket(f, t, p int) (int, error) { ...

12 years, 2 months ago (2013-01-28 17:36:05 UTC) #3

iant

12 years, 2 months ago (2013-01-28 17:37:29 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=327ed227a2f7 ***

net: fix windows build

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7229050

Expand All Messages | Collapse All Messages