Issue 7228081: code review 7228081: runtime: cgo-related fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7228081: code review 7228081: runtime: cgo-related fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

runtime: cgo-related fixes * Separate internal and external LockOSThread, for cgo safety. * Show goroutine that made faulting cgo call. * Never start a panic due to a signal caused by a cgo call. Fixes issue 3774. Fixes issue 3775. Fixes issue 3797.

Patch Set 1 #

Patch Set 2 : diff -r 445186a20cee https://code.google.com/p/go/ #

Patch Set 3 : diff -r 10d1582a1129 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 77311c93224c https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -61 lines)			Patch
M	misc/cgo/test/cgo_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	misc/cgo/test/issue3775.go	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgocall.c	View	1	3 chunks	+13 lines, -29 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	5 chunks	+39 lines, -16 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/signal_darwin_386.c	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/signal_darwin_amd64.c	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/signal_freebsd_386.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_freebsd_amd64.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_freebsd_arm.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_linux_386.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_linux_amd64.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_linux_arm.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_netbsd_386.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_netbsd_amd64.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_openbsd_386.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_openbsd_amd64.c	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/signal_windows_386.c	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/signal_windows_amd64.c	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/traceback_arm.c	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/traceback_x86.c	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-02-01 06:03:43 UTC) #1

rsc

12 years, 2 months ago (2013-02-01 16:35:22 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=78b628de661a ***

runtime: cgo-related fixes

* Separate internal and external LockOSThread, for cgo safety.
* Show goroutine that made faulting cgo call.
* Never start a panic due to a signal caused by a cgo call.

Fixes issue 3774.
Fixes issue 3775.
Fixes issue 3797.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7228081

Expand All Messages | Collapse All Messages