Issue 7228061: code review 7228061: encoding/json: add test for Unmarshal of malformed data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7228061: code review 7228061: encoding/json: add test for Unmarshal of malformed data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

encoding/json: add test for Unmarshal of malformed data Roll back CL making primitive type unmarshal faster, because it broke the Unmarshal of malformed data. Add benchmarks for unmarshal of primitive types. Update issue 3949.

Patch Set 1 #

Patch Set 2 : diff -r 74ba903952d9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a7e82245c7d5 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -21 lines)			Patch
M	src/pkg/encoding/json/bench_test.go	View	1	1 chunk	+33 lines, -1 line	0 comments	Download
M	src/pkg/encoding/json/decode.go	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/pkg/encoding/json/decode_test.go	View	1	1 chunk	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-01-29 21:10:36 UTC) #1

rsc

12 years, 1 month ago (2013-01-29 21:34:23 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=715674f61ae8 ***

encoding/json: add test for Unmarshal of malformed data

Roll back CL making primitive type unmarshal faster,
because it broke the Unmarshal of malformed data.

Add benchmarks for unmarshal of primitive types.

Update issue 3949.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7228061

Expand All Messages | Collapse All Messages