code review 7221055: go/misc/dist: Keep file modes when copying.

go/misc/dist: Keep file modes when copying.

[francesc, 2013-01-29 05:53:42]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2013-01-29 06:29:06]

https://codereview.appspot.com/7221055/diff/3/misc/dist/bindist.go
File misc/dist/bindist.go (right):

https://codereview.appspot.com/7221055/diff/3/misc/dist/bindist.go#newcode619
misc/dist/bindist.go:619: stat, err := sf.Stat()
put the stat before the call to os.Create(dst); we shouldn't create dst if we
can't stat src

https://codereview.appspot.com/7221055/diff/3/misc/dist/bindist.go#newcode623
misc/dist/bindist.go:623: df.Chmod(stat.Mode())
check the error return value

[francesc, 2013-01-29 07:50:09]

PTAL

https://codereview.appspot.com/7221055/diff/3/misc/dist/bindist.go
File misc/dist/bindist.go (right):

https://codereview.appspot.com/7221055/diff/3/misc/dist/bindist.go#newcode619
misc/dist/bindist.go:619: stat, err := sf.Stat()
On 2013/01/29 06:29:06, adg wrote:
> put the stat before the call to os.Create(dst); we shouldn't create dst if we
> can't stat src

Done.

https://codereview.appspot.com/7221055/diff/3/misc/dist/bindist.go#newcode623
misc/dist/bindist.go:623: df.Chmod(stat.Mode())
On 2013/01/29 06:29:06, adg wrote:
> check the error return value

Done.

[adg, 2013-01-29 22:12:29]

LGTM

https://codereview.appspot.com/7221055/diff/7001/misc/dist/bindist.go
File misc/dist/bindist.go (right):

https://codereview.appspot.com/7221055/diff/7001/misc/dist/bindist.go#newcode614
misc/dist/bindist.go:614: stat, err := sf.Stat()
s/stat/fi/

because it's a FileInfo value

[francesc, 2013-01-29 23:17:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=3934c2800dca ***

go/misc/dist: Keep file modes when copying.

R=adg
CC=golang-dev
https://codereview.appspot.com/7221055

https://codereview.appspot.com/7221055/diff/7001/misc/dist/bindist.go
File misc/dist/bindist.go (right):

https://codereview.appspot.com/7221055/diff/7001/misc/dist/bindist.go#newcode614
misc/dist/bindist.go:614: stat, err := sf.Stat()
On 2013/01/29 22:12:29, adg wrote:
> s/stat/fi/
> 
> because it's a FileInfo value

Done.