Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(515)

Issue 7218044: code review 7218044: runtime/race: switch to explicit race context instead o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by dvyukov
Modified:
12 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

runtime/race: switch to explicit race context instead of goroutine id's Removes limit on maximum number of goroutines ever existed. code.google.com/p/goexecutor tests now pass successfully. Also slightly improves performance. Before: $ time ./flate.test -test.short real 0m9.314s After: $ time ./flate.test -test.short real 0m8.958s Fixes issue 4286. The runtime is built from llvm rev 174312.

Patch Set 1 #

Patch Set 2 : diff -r 1eadf11dd1b7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 1eadf11dd1b7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 1eadf11dd1b7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 1eadf11dd1b7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r e2f9b9a58240 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 8d71734a0cb0 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -101 lines) Patch
M src/pkg/runtime/proc.c View 1 2 3 4 5 6 chunks +8 lines, -7 lines 0 comments Download
M src/pkg/runtime/race.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/race.c View 1 13 chunks +47 lines, -43 lines 0 comments Download
M src/pkg/runtime/race/race.go View 1 3 chunks +42 lines, -42 lines 0 comments Download
M src/pkg/runtime/race/race_darwin_amd64.syso View 1 2 3 4 5 Binary file 0 comments Download
M src/pkg/runtime/race/race_linux_amd64.syso View 1 2 3 4 5 Binary file 0 comments Download
M src/pkg/runtime/race/race_windows_amd64.syso View 1 2 3 4 5 Binary file 0 comments Download
M src/pkg/runtime/race0.c View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years, 1 month ago (2013-01-30 19:27:16 UTC) #1
dvyukov
I will build/test/upload darwin/windows syso a bit later.
12 years, 1 month ago (2013-01-30 19:28:02 UTC) #2
dvyukov
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 1 month ago (2013-02-04 08:09:09 UTC) #3
dvyukov
On 2013/01/30 19:28:02, dvyukov wrote: > I will build/test/upload darwin/windows syso a bit later. Uploaded ...
12 years, 1 month ago (2013-02-04 08:09:56 UTC) #4
rsc
LGTM
12 years, 1 month ago (2013-02-05 12:04:16 UTC) #5
dvyukov
12 years, 1 month ago (2013-02-06 07:41:05 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=c05803c8e145 ***

runtime/race: switch to explicit race context instead of goroutine id's
Removes limit on maximum number of goroutines ever existed.
code.google.com/p/goexecutor tests now pass successfully.
Also slightly improves performance.
Before: $ time ./flate.test -test.short
real	0m9.314s
After:  $ time ./flate.test -test.short
real	0m8.958s
Fixes issue 4286.
The runtime is built from llvm rev 174312.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7218044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b