code review 7206049: go/build: document blank line required after build cons...

go/build: document blank line required after build constraints

Fixes issue 3539.

[rick, 2013-01-24 01:50:29]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-01-24 01:55:53]

https://codereview.appspot.com/7206049/diff/4001/src/pkg/go/build/doc.go
File src/pkg/go/build/doc.go (right):

https://codereview.appspot.com/7206049/diff/4001/src/pkg/go/build/doc.go#newc...
src/pkg/go/build/doc.go:63: // they must appear near the top of the file,
preceded
please reformat for 80 cols

https://codereview.appspot.com/7206049/diff/4001/src/pkg/go/build/doc.go#newc...
src/pkg/go/build/doc.go:64: // only by blank lines and other line comments. To
distinguish
I think this warrants a new paragraph, we'll be referring to it often.

[rick, 2013-01-24 02:09:38]

PTAL

https://codereview.appspot.com/7206049/diff/4001/src/pkg/go/build/doc.go
File src/pkg/go/build/doc.go (right):

https://codereview.appspot.com/7206049/diff/4001/src/pkg/go/build/doc.go#newc...
src/pkg/go/build/doc.go:63: // they must appear near the top of the file,
preceded
On 2013/01/24 01:55:54, dfc wrote:
> please reformat for 80 cols

I'm not sure what you mean... it fits in 80 cols already. Do you mean change all
the existing lines (that I didn't touch) to fit 80 cols?

https://codereview.appspot.com/7206049/diff/4001/src/pkg/go/build/doc.go#newc...
src/pkg/go/build/doc.go:64: // only by blank lines and other line comments. To
distinguish
On 2013/01/24 01:55:54, dfc wrote:
> I think this warrants a new paragraph, we'll be referring to it often.

Done.

[adg, 2013-01-24 02:19:48]

https://codereview.appspot.com/7206049/diff/1003/src/pkg/go/build/doc.go
File src/pkg/go/build/doc.go (right):

https://codereview.appspot.com/7206049/diff/1003/src/pkg/go/build/doc.go#newc...
src/pkg/go/build/doc.go:66: // To distinguish build constraints from package
documentation, a blank line
... a series of build constraints must be followed by a blank line.

[rick, 2013-01-24 02:24:04]

PTAL

https://codereview.appspot.com/7206049/diff/1003/src/pkg/go/build/doc.go
File src/pkg/go/build/doc.go (right):

https://codereview.appspot.com/7206049/diff/1003/src/pkg/go/build/doc.go#newc...
src/pkg/go/build/doc.go:66: // To distinguish build constraints from package
documentation, a blank line
On 2013/01/24 02:19:48, adg wrote:
> ... a series of build constraints must be followed by a blank line.

Done.

[adg, 2013-01-24 02:32:28]

LGTM

[adg, 2013-01-24 02:32:54]

*** Submitted as https://code.google.com/p/go/source/detail?r=76dc0d7cec07 ***

go/build: document blank line required after build constraints

Fixes issue 3539.

R=golang-dev, dave, adg
CC=golang-dev
https://codereview.appspot.com/7206049

Committer: Andrew Gerrand <adg@golang.org>