code review 7197046: syscall: regenerate ztype files for linux

syscall: regenerate ztype files for linux

This CL adds TCPInfo struct to linux/386,arm.
It's already added to linux/amd64.

Note that not sure the reason but cgo godefs w/ latest gcc
translates a flexible array member in structures correctly,
handles it as a non-incomplete, non-opaque type, on Go 1.
This CL reverts such changes by hand for the Go 1 contract.

[mikio, 2013-01-23 15:28:11]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2013-01-23 15:33:17]

On Thu, Jan 24, 2013 at 12:28 AM,  <mikioh.mikioh@gmail.com> wrote:

> +pkg syscall (linux-386), type Cmsghdr struct, X__cmsg_data [0]byte

latest go tool cgo -godefs uses uint8 instead of byte,

> +pkg syscall (linux-386), type InotifyEvent struct, Name [0]byte

and captures "char name[] of inotify_event" correctly.

[minux1, 2013-01-23 17:06:13]

so we just add entries to api/except.txt so easily? i guess we shouldn't.

On Wed, Jan 23, 2013 at 11:33 PM, Mikio Hara <mikioh.mikioh@gmail.com>wrote:

> On Thu, Jan 24, 2013 at 12:28 AM,  <mikioh.mikioh@gmail.com> wrote:
>
> > +pkg syscall (linux-386), type Cmsghdr struct, X__cmsg_data [0]byte
>
> latest go tool cgo -godefs uses uint8 instead of byte,
>
I'd rather fix cmd/cgo to generate byte for these two cases to minimise the
number of entries added to api/except.txt.

>
> > +pkg syscall (linux-386), type InotifyEvent struct, Name [0]byte
>
> and captures "char name[] of inotify_event" correctly.
>

[bradfitz, 2013-01-23 17:39:51]

We could also just teach cmd/api that uint8 and byte are the same.

I'd rather not update except.txt with this CL.  It's not very exceptional.


On Wed, Jan 23, 2013 at 9:05 AM, minux <minux.ma@gmail.com> wrote:

> so we just add entries to api/except.txt so easily? i guess we shouldn't.
>
> On Wed, Jan 23, 2013 at 11:33 PM, Mikio Hara <mikioh.mikioh@gmail.com>wrote:
>
>> On Thu, Jan 24, 2013 at 12:28 AM,  <mikioh.mikioh@gmail.com> wrote:
>>
>> > +pkg syscall (linux-386), type Cmsghdr struct, X__cmsg_data [0]byte
>>
>> latest go tool cgo -godefs uses uint8 instead of byte,
>>
> I'd rather fix cmd/cgo to generate byte for these two cases to minimise the
> number of entries added to api/except.txt.
>
>>
>> > +pkg syscall (linux-386), type InotifyEvent struct, Name [0]byte
>>
>> and captures "char name[] of inotify_event" correctly.
>>
>
>

[mikio, 2013-01-23 22:12:48]

yup, will do.

On Thu, Jan 24, 2013 at 2:39 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> We could also just teach cmd/api that uint8 and byte are the same.
>
> I'd rather not update except.txt with this CL.  It's not very exceptional.
>
>
> On Wed, Jan 23, 2013 at 9:05 AM, minux <minux.ma@gmail.com> wrote:
>>
>> so we just add entries to api/except.txt so easily? i guess we shouldn't.
>>
>> On Wed, Jan 23, 2013 at 11:33 PM, Mikio Hara <mikioh.mikioh@gmail.com>
>> wrote:
>>>
>>> On Thu, Jan 24, 2013 at 12:28 AM,  <mikioh.mikioh@gmail.com> wrote:
>>>
>>> > +pkg syscall (linux-386), type Cmsghdr struct, X__cmsg_data [0]byte
>>>
>>> latest go tool cgo -godefs uses uint8 instead of byte,
>>
>> I'd rather fix cmd/cgo to generate byte for these two cases to minimise
>> the
>> number of entries added to api/except.txt.
>>>
>>>
>>> > +pkg syscall (linux-386), type InotifyEvent struct, Name [0]byte
>>>
>>> and captures "char name[] of inotify_event" correctly.
>>
>>
>

[bradfitz, 2013-01-23 23:43:37]

or let me know if you want me to.  I'll assume you'll send that CL first if
not.

On Wed, Jan 23, 2013 at 2:12 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> yup, will do.
>
> On Thu, Jan 24, 2013 at 2:39 AM, Brad Fitzpatrick <bradfitz@golang.org>
> wrote:
>
> > We could also just teach cmd/api that uint8 and byte are the same.
> >
> > I'd rather not update except.txt with this CL.  It's not very
> exceptional.
> >
> >
> > On Wed, Jan 23, 2013 at 9:05 AM, minux <minux.ma@gmail.com> wrote:
> >>
> >> so we just add entries to api/except.txt so easily? i guess we
> shouldn't.
> >>
> >> On Wed, Jan 23, 2013 at 11:33 PM, Mikio Hara <mikioh.mikioh@gmail.com>
> >> wrote:
> >>>
> >>> On Thu, Jan 24, 2013 at 12:28 AM,  <mikioh.mikioh@gmail.com> wrote:
> >>>
> >>> > +pkg syscall (linux-386), type Cmsghdr struct, X__cmsg_data [0]byte
> >>>
> >>> latest go tool cgo -godefs uses uint8 instead of byte,
> >>
> >> I'd rather fix cmd/cgo to generate byte for these two cases to minimise
> >> the
> >> number of entries added to api/except.txt.
> >>>
> >>>
> >>> > +pkg syscall (linux-386), type InotifyEvent struct, Name [0]byte
> >>>
> >>> and captures "char name[] of inotify_event" correctly.
> >>
> >>
> >
>

[mikio, 2013-01-23 23:53:35]

On Thu, Jan 24, 2013 at 8:43 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> or let me know if you want me to.  I'll assume you'll send that CL first if
> not.

oh, please and thank you.

[mikio, 2013-02-02 01:35:30]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-02-02 02:08:13]

https://codereview.appspot.com/7197046/diff/13001/api/go1.txt
File api/go1.txt (right):

https://codereview.appspot.com/7197046/diff/13001/api/go1.txt#newcode19054
api/go1.txt:19054: +pkg syscall (linux-386), type InotifyEvent struct, Name
[0]int8
This is an API change. We promised not to do this.

[mikio, 2013-02-02 02:22:53]

Hello minux.ma@gmail.com, bradfitz@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-02-04 17:29:26]

LGTM

On Fri, Feb 1, 2013 at 6:22 PM, <mikioh.mikioh@gmail.com> wrote:

> Hello minux.ma@gmail.com, bradfitz@golang.org, rsc@golang.org (cc:
>
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/7197046/<https://codereview.appspot.com/7197...
>

[mikio, 2013-02-04 21:54:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=00a88d8b0fad ***

syscall: regenerate ztype files for linux

This CL adds TCPInfo struct to linux/386,arm.
It's already added to linux/amd64.

Note that not sure the reason but cgo godefs w/ latest gcc
translates a flexible array member in structures correctly,
handles it as a non-incomplete, non-opaque type, on Go 1.
This CL reverts such changes by hand for the Go 1 contract.

R=minux.ma, bradfitz, rsc
CC=golang-dev
https://codereview.appspot.com/7197046