code review 7195043: go-tour: fix app engine version, restoring online-speci...

go-tour: fix app engine version, restoring online-specific content

[adg, 2013-01-23 08:53:29]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-tour

[minux1, 2013-01-23 09:31:12]

https://codereview.appspot.com/7195043/diff/4009/tour.article
File tour.article (right):

https://codereview.appspot.com/7195043/diff/4009/tour.article#newcode7
tour.article:7: # the string # "#appengine: ". These lines are included in
extra # before "#appengine"?

https://codereview.appspot.com/7195043/diff/4009/tour.article#newcode9
tour.article:9: # Furthermore, any non-blank like that immediately follows a
s/like/line/

Your description makes me wonder whether line 2
will be hidden or not.

#appengine: appengine content
line 1
line 2

#appengine: ....

https://codereview.appspot.com/7195043/diff/4009/tour.article#newcode37
tour.article:37: * Go local
in the original tour, this page is only
shown in appengine mode.

also, it seems you've omitted the appengine-only
"go offline" section.

[adg, 2013-01-23 09:38:52]

PTAL

Thanks minux.

https://codereview.appspot.com/7195043/diff/4009/tour.article
File tour.article (right):

https://codereview.appspot.com/7195043/diff/4009/tour.article#newcode7
tour.article:7: # the string # "#appengine: ". These lines are included in
On 2013/01/23 09:31:12, minux wrote:
> extra # before "#appengine"?

Done.

https://codereview.appspot.com/7195043/diff/4009/tour.article#newcode9
tour.article:9: # Furthermore, any non-blank like that immediately follows a
On 2013/01/23 09:31:12, minux wrote:
> s/like/line/
> 
> Your description makes me wonder whether line 2
> will be hidden or not.
> 
> #appengine: appengine content
> line 1
> line 2
> 
> #appengine: ....

clarified

https://codereview.appspot.com/7195043/diff/4009/tour.article#newcode37
tour.article:37: * Go local
On 2013/01/23 09:31:12, minux wrote:
> in the original tour, this page is only
> shown in appengine mode.

Yep, I figured there's no reason it shouldn't be visible locally.

> also, it seems you've omitted the appengine-only
> "go offline" section.

Yep, this is deliberate.  As campoy is working on zip file downloads of the
tour, the offline instructions will change soon.

[adg, 2013-01-24 22:25:10]

R=campoy

[minux1, 2013-01-24 22:29:32]

non-appengine parts LGTM.

[francesc, 2013-01-24 22:42:22]

https://codereview.appspot.com/7195043/diff/11001/app.yaml
File app.yaml (right):

https://codereview.appspot.com/7195043/diff/11001/app.yaml#newcode14
app.yaml:14: - url: /(|compile|fmt)
I see that you're accepting /fmt requests here, but I don't see how you handle
them in the Go code.

Am I missing something?

https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go
File gotour/appengine.go (right):

https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go#newcode24
gotour/appengine.go:24: http.HandleFunc("/compile", compileHandler)
What about /fmt?

https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go#newcode86
gotour/appengine.go:86: w.Close()
Should you return after closing the writer?

https://codereview.appspot.com/7195043/diff/11001/gotour/local.go
File gotour/local.go (right):

https://codereview.appspot.com/7195043/diff/11001/gotour/local.go#newcode80
gotour/local.go:80: http.Error(w, "not found", 404)
What about /fmt?

[adg, 2013-01-24 23:08:12]

https://codereview.appspot.com/7195043/diff/11001/app.yaml
File app.yaml (right):

https://codereview.appspot.com/7195043/diff/11001/app.yaml#newcode14
app.yaml:14: - url: /(|compile|fmt)
On 2013/01/24 22:42:23, gocampoy wrote:
> I see that you're accepting /fmt requests here, but I don't see how you handle
> them in the Go code.
> 
> Am I missing something?

Yes. There is a fmt.go in the gotour directory that is not affected by this CL.
It implements the /fmt handler.

https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go
File gotour/appengine.go (right):

https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go#newcode86
gotour/appengine.go:86: w.Close()
On 2013/01/24 22:42:23, gocampoy wrote:
> Should you return after closing the writer?

Done.

[campoy, 2013-01-24 23:13:16]

https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go
File gotour/appengine.go (right):

https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go#newcode86
gotour/appengine.go:86: w.Close()
I don't see it done. Did you upload?

On 2013/01/24 23:08:12, adg wrote:
> On 2013/01/24 22:42:23, gocampoy wrote:
> > Should you return after closing the writer?
> 
> Done.

[adg, 2013-01-24 23:15:40]

On 25 January 2013 10:13, <campoy@google.com> wrote:

>
>
https://codereview.appspot.**com/7195043/diff/11001/gotour/**appengine.go<htt...
> File gotour/appengine.go (right):
>
> https://codereview.appspot.**com/7195043/diff/11001/gotour/**
>
appengine.go#newcode86<https://codereview.appspot.com/7195043/diff/11001/gotour/appengine.go#newcode86>
> gotour/appengine.go:86: w.Close()
> I don't see it done. Did you upload?
>

Yes, but:

$ hg upload 7195043
Exception in thread Thread-4:
Traceback (most recent call last):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 552, in __bootstrap_inner
    self.run()
  File "/Users/adg/go/lib/codereview/codereview.py", line 3270, in run
    UploadFile(*self.args)
  File "/Users/adg/go/lib/codereview/codereview.py", line 3250, in
UploadFile
    response_body = rpc_server.Send(url, body, content_type=ctype)
  File "/Users/adg/go/lib/codereview/codereview.py", line 2943, in Send
    f = self.opener.open(req)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 400, in open
    response = meth(req, response)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 513, in http_response
    'http', request, response, code, msg, hdrs)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 438, in error
    return self._call_chain(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 372, in _call_chain
    result = func(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 521, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 500: Internal Server Error

Exception in thread Thread-2:
Traceback (most recent call last):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 552, in __bootstrap_inner
    self.run()
  File "/Users/adg/go/lib/codereview/codereview.py", line 3270, in run
    UploadFile(*self.args)
  File "/Users/adg/go/lib/codereview/codereview.py", line 3250, in
UploadFile
    response_body = rpc_server.Send(url, body, content_type=ctype)
  File "/Users/adg/go/lib/codereview/codereview.py", line 2943, in Send
    f = self.opener.open(req)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 400, in open
    response = meth(req, response)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 513, in http_response
    'http', request, response, code, msg, hdrs)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 438, in error
    return self._call_chain(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 372, in _call_chain
    result = func(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 521, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 500: Internal Server Error

Exception in thread Thread-1:
Traceback (most recent call last):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 552, in __bootstrap_inner
    self.run()
  File "/Users/adg/go/lib/codereview/codereview.py", line 3270, in run
    UploadFile(*self.args)
  File "/Users/adg/go/lib/codereview/codereview.py", line 3250, in
UploadFile
    response_body = rpc_server.Send(url, body, content_type=ctype)
  File "/Users/adg/go/lib/codereview/codereview.py", line 2943, in Send
    f = self.opener.open(req)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 400, in open
    response = meth(req, response)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 513, in http_response
    'http', request, response, code, msg, hdrs)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 438, in error
    return self._call_chain(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 372, in _call_chain
    result = func(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 521, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 500: Internal Server Error

Exception in thread Thread-3:
Traceback (most recent call last):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 552, in __bootstrap_inner
    self.run()
  File "/Users/adg/go/lib/codereview/codereview.py", line 3270, in run
    UploadFile(*self.args)
  File "/Users/adg/go/lib/codereview/codereview.py", line 3250, in
UploadFile
    response_body = rpc_server.Send(url, body, content_type=ctype)
  File "/Users/adg/go/lib/codereview/codereview.py", line 2943, in Send
    f = self.opener.open(req)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 400, in open
    response = meth(req, response)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 513, in http_response
    'http', request, response, code, msg, hdrs)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 438, in error
    return self._call_chain(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 372, in _call_chain
    result = func(*args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 521, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 500: Internal Server Error

^C^C^C


Trying again :-)

[adg, 2013-01-24 23:15:56]

Hello minux.ma@gmail.com, campoy@google.com, campoy@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[francesc, 2013-01-24 23:17:27]

LGTM

On 2013/01/24 23:15:56, adg wrote:
> Hello mailto:minux.ma@gmail.com, mailto:campoy@google.com,
mailto:campoy@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[francesc, 2013-01-24 23:17:27]

LGTM

On 2013/01/24 23:15:56, adg wrote:
> Hello mailto:minux.ma@gmail.com, mailto:campoy@google.com,
mailto:campoy@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[adg, 2013-01-24 23:24:40]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=f4e0d46f0c64
***

go-tour: fix app engine version, restoring online-specific content

R=minux.ma, campoy, campoy
CC=golang-dev
https://codereview.appspot.com/7195043