all: use t.Skip{,f}

all: use t.Skip{,f}

Replace various t.Log{,f} ; return checks with t.Skip{,f}.

[dave_cheney.net, 2013-01-23 10:30:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-01-23 10:31:36]

On 2013/01/23 10:30:51, dfc wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

I would be grateful to folks who can test this on windows and the *bsds.

[niemeyer, 2013-01-23 15:52:16]

https://codereview.appspot.com/7193044/diff/4002/src/pkg/net/dial_test.go
File src/pkg/net/dial_test.go (right):

https://codereview.appspot.com/7193044/diff/4002/src/pkg/net/dial_test.go#new...
src/pkg/net/dial_test.go:77: t.Skipf("skipping test on %q; untested.",
runtime.GOOS)
While before it made sense to say "skipping test", this seems implied now. With
gocheck I use the equivalent of this:

  t.Skipf("untested on %q", runtime.GOOS)

[bradfitz, 2013-01-23 17:52:43]

LGTM

Thanks for doing this! Great cleanup.

The builders are all happy again, so feel free to submit whenever.
 Breakages are easy to fix afterwards.  I see nothing scary, though.

On Wed, Jan 23, 2013 at 2:31 AM, <dave@cheney.net> wrote:

> On 2013/01/23 10:30:51, dfc wrote:
>
>> Hello mailto:golang-dev@**googlegroups.com <golang-dev@googlegroups.com>,
>>
>
>  I'd like you to review this change to
>> https://code.google.com/p/go
>>
>
> I would be grateful to folks who can test this on windows and the *bsds.
>
>
>
https://codereview.appspot.**com/7193044/<https://codereview.appspot.com/7193...
>

[adg, 2013-01-23 22:30:54]

LGTM

https://codereview.appspot.com/7193044/diff/4002/src/pkg/net/dial_test.go
File src/pkg/net/dial_test.go (right):

https://codereview.appspot.com/7193044/diff/4002/src/pkg/net/dial_test.go#new...
src/pkg/net/dial_test.go:77: t.Skipf("skipping test on %q; untested.",
runtime.GOOS)
On 2013/01/23 15:52:16, niemeyer wrote:
> While before it made sense to say "skipping test", this seems implied now.
With
> gocheck I use the equivalent of this:
> 
>   t.Skipf("untested on %q", runtime.GOOS)

That's a good practice, but I don't think Dave need to go to the trouble in this
CL.

[dave_cheney.net, 2013-01-24 01:18:51]

Thanks for your kind comments Brad. I'll submit this CL in the next day or after
I give it a final once over.

[mikio, 2013-01-24 02:21:53]

> I would be grateful to folks who can test this on windows and the *bsds.

passed tests on freebsd/amd64.

[dave_cheney.net, 2013-01-24 06:32:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=6206c68b2d29 ***

all: use t.Skip{,f}

Replace various t.Log{,f} ; return checks with t.Skip{,f}.

R=golang-dev, n13m3y3r, bradfitz, adg, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7193044