code review 71900045: os: document that Process.Wait only works on child processes

os: document that Process.Wait only works on child processes

Fixes Issue 7072

[bradfitz, 2014-03-06 18:59:36]

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant, 2014-03-06 19:42:29]

LGTM

https://codereview.appspot.com/71900045/diff/40001/src/pkg/os/doc.go
File src/pkg/os/doc.go (right):

https://codereview.appspot.com/71900045/diff/40001/src/pkg/os/doc.go#newcode42
src/pkg/os/doc.go:42: // On most operating systems, the Process must be a child
Suggest s/child process/child of the current process/

[bradfitz, 2014-03-07 22:44:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=fb17c23eee74 ***

os: document that Process.Wait only works on child processes

Fixes Issue 7072

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/71900045

[gobot, 2014-03-07 22:51:09]

This CL appears to have broken the freebsd-amd64 builder.

[mikio, 2014-03-07 23:07:47]

not related to this cl, but it looks real.

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestFutexsleep-2 (0.00 seconds)
futex_test.go:61: futexsleep test "after the year 2038" finished early
after 26.518us
FAIL

hm, futexsleep on both BSDs has some issue especially when it runs
with ncpu=2 or more.

[bradfitz, 2014-03-08 01:00:36]

Please file a bug if it's real.



On Fri, Mar 7, 2014 at 3:07 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> not related to this cl, but it looks real.
>
> # GOMAXPROCS=2 runtime -cpu=1,2,4
> --- FAIL: TestFutexsleep-2 (0.00 seconds)
> futex_test.go:61: futexsleep test "after the year 2038" finished early
> after 26.518us
> FAIL
>
> hm, futexsleep on both BSDs has some issue especially when it runs
> with ncpu=2 or more.
>

[mikio, 2014-03-08 01:10:24]

done: golang.org/issue/7496

On Sat, Mar 8, 2014 at 10:00 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Please file a bug if it's real.
>
>
>
> On Fri, Mar 7, 2014 at 3:07 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
>>
>> not related to this cl, but it looks real.
>>
>> # GOMAXPROCS=2 runtime -cpu=1,2,4
>> --- FAIL: TestFutexsleep-2 (0.00 seconds)
>> futex_test.go:61: futexsleep test "after the year 2038" finished early
>> after 26.518us
>> FAIL
>>
>> hm, futexsleep on both BSDs has some issue especially when it runs
>> with ncpu=2 or more.
>
>