Issue 7181052: code review 7181052: time: make TestReset more reliable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7181052: code review 7181052: time: make TestReset more reliable (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bradfitz

Modified:
11 years, 3 months ago

Reviewers:

CC:
golang-dev, brainman, mikio

Visibility:
Public.

Description

time: make TestReset more reliable Fixes issue 4690

Patch Set 2 : diff -r 0aa3f72c1c8b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0aa3f72c1c8b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r c3f6b7dd0104 https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -10 lines)			Patch
	M	src/pkg/time/sleep_test.go	View	1 2 3	1 chunk	+33 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2013-01-23 00:30:49 UTC) #1

mikio

LGTM https://codereview.appspot.com/7181052/diff/4002/src/pkg/time/sleep_test.go File src/pkg/time/sleep_test.go (right): https://codereview.appspot.com/7181052/diff/4002/src/pkg/time/sleep_test.go#newcode283 src/pkg/time/sleep_test.go:283: 500 * Millisecond, or maybe bin exp. backoff ...

11 years, 3 months ago (2013-01-23 01:16:11 UTC) #3

bradfitz

11 years, 3 months ago (2013-01-23 01:26:01 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=a50963036915 ***

time: make TestReset more reliable

Fixes issue 4690

R=golang-dev, alex.brainman, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7181052

Expand All Messages | Collapse All Messages