Issue 7161043: code review 7161043: crypto/cipher: don't persist errors in StreamWriter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7161043: code review 7161043: crypto/cipher: don't persist errors in StreamWriter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by agl1

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

crypto/cipher: don't persist errors in StreamWriter. I messed this up from the beginning. The receiver isn't a pointer so setting Err is useless. In order to maintain the API, just remove the superfluous code. Fixes issue 4657.

Patch Set 1 : diff -r 7418ae25fbb4 https://code.google.com/p/go/ #

Patch Set 2 : diff -r 7418ae25fbb4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7dc8d66efb6d https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	src/pkg/crypto/cipher/io.go	View		2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-01-17 20:24:20 UTC) #1

agl1

12 years, 2 months ago (2013-01-21 16:22:22 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=91ecf40e26ae ***

crypto/cipher: don't persist errors in StreamWriter.

I messed this up from the beginning. The receiver isn't a pointer so
setting Err is useless. In order to maintain the API, just remove the
superfluous code.

Fixes issue 4657.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7161043

Expand All Messages | Collapse All Messages