Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 71590043: code review 71590043: encoding/gob: improve interface assignment error ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by hightower
Modified:
10 years ago
Reviewers:
r
CC:
golang-codereviews, rsc, r
Visibility:
Public.

Description

encoding/gob: improve interface assignment error message During the glob decoding process interface values are set to concrete values after a test for assignability. If the assignability test fails a slightly vague error message is produced. While technically accurate the error message does not clearly describe the problem. Rewrite the error message to include the usage of the word assignable, which makes it clear the concrete value type is not assignable to the interface value type. Fixes issue 6467.

Patch Set 1 #

Patch Set 2 : diff -r 1a0714819799 https://code.google.com/p/go #

Patch Set 3 : diff -r 1a0714819799 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/encoding/gob/decode.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
hightower
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years ago (2014-03-05 17:04:58 UTC) #1
rsc
R=r please fix cl description indentation and s/glob/gob/
10 years ago (2014-03-05 19:47:41 UTC) #2
r
LGTM
10 years ago (2014-03-05 19:48:49 UTC) #3
r
P.S. I deleted the leading spaces on the first line of the CL description.
10 years ago (2014-03-05 19:51:27 UTC) #4
r
10 years ago (2014-03-05 19:52:36 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=11209a881ff0 ***

encoding/gob: improve interface assignment error message

During the glob decoding process interface values are set to concrete
values after a test for assignability. If the assignability test fails
a slightly vague error message is produced. While technically accurate
the error message does not clearly describe the problem.

Rewrite the error message to include the usage of the word assignable,
which makes it clear the concrete value type is not assignable to the
interface value type.

Fixes issue 6467.

LGTM=r
R=golang-codereviews, rsc, r
CC=golang-codereviews
https://codereview.appspot.com/71590043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b