Issue 7137063: code review 7137063: undo CL 5687057 / 58bc8aae4abb

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7137063: code review 7137063: undo CL 5687057 / 58bc8aae4abb (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by mikio

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

undo CL 5687057 / 58bc8aae4abb Fortunately we have never seen the panic on sockaddrToTCP in the past year. ««« original CL description net: panic if sockaddrToTCP returns nil incorrectly Part of diagnosing the selfConnect bug TBR=dsymonds R=golang-dev CC=golang-dev http://codereview.appspot.com/5687057 »»»

Patch Set 1 #

Patch Set 2 : diff -r b14680735334 https://code.google.com/p/go #

Patch Set 3 : diff -r b14680735334 https://code.google.com/p/go #

Patch Set 4 : diff -r c4ee14785641 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	src/pkg/net/tcpsock_posix.go	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-01-19 09:49:44 UTC) #1

mikio

12 years, 3 months ago (2013-01-19 14:13:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0fcf167dc85f ***

undo CL 5687057 / 58bc8aae4abb

Fortunately we have never seen the panic on sockaddrToTCP
in the past year.

««« original CL description
net: panic if sockaddrToTCP returns nil incorrectly
Part of diagnosing the selfConnect bug
TBR=dsymonds

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5687057
»»»

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7137063

Expand All Messages | Collapse All Messages