Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(428)

Issue 7132050: code review 7132050: testing: allow examples to pass (fix build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by adg
Modified:
12 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-dev
Visibility:
Public.

Description

testing: allow examples to pass (fix build)

Patch Set 1 #

Patch Set 2 : diff -r 938597eab997 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/testing/example.go View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2013-01-18 01:23:56 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=dff6e212f5cb *** testing: allow examples to pass (fix build) R=golang-dev CC=golang-dev https://codereview.appspot.com/7132050
12 years, 3 months ago (2013-01-18 01:25:50 UTC) #2
bradfitz
12 years, 3 months ago (2013-01-18 02:43:21 UTC) #3
LGTM

On Thu, Jan 17, 2013 at 5:23 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> testing: allow examples to pass (fix build)
>
> Please review this at
https://codereview.appspot.**com/7132050/<https://codereview.appspot.com/7132...
>
> Affected files:
>   M src/pkg/testing/example.go
>
>
> Index: src/pkg/testing/example.go
> ==============================**==============================**=======
> --- a/src/pkg/testing/example.go
> +++ b/src/pkg/testing/example.go
> @@ -67,6 +67,7 @@
>         }()
>
>         start := time.Now()
> +       ok = true
>
>         // Clean up in a deferred call so we can recover if the example
> panics.
>         defer func() {
> @@ -84,6 +85,7 @@
>                 }
>                 if fail != "" || err != nil {
>                         fmt.Printf("--- FAIL: %s (%v)\n%s", eg.Name, d,
> fail)
> +                       ok = false
>                 } else if *chatty {
>                         fmt.Printf("--- PASS: %s (%v)\n", eg.Name, d)
>                 }
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b