Issue 7128045: code review 7128045: cmd/6c, cmd/8c: fix print format for Prog

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7128045: code review 7128045: cmd/6c, cmd/8c: fix print format for Prog (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by ality

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/6c, cmd/8c: fix print format for Prog The FmtLong flag should only be used with the %D verb when printing an ATEXT Prog. It was erroneously used for every Prog except ADATA. This caused a preponderance of exclamation points, "!!", in the assembly listings. I also cleaned up the code so that the list.c files look very similar. Now the real differences are easily spotted with a simple diff.

Patch Set 1 #

Patch Set 2 : diff -r 3914255bcf5f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3914255bcf5f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6287072632c4 https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -49 lines)			Patch
	M	src/cmd/6c/list.c	View	1	11 chunks	+24 lines, -29 lines	0 comments	Download
	M	src/cmd/8c/list.c	View	1	13 chunks	+35 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2013-01-17 08:58:42 UTC) #1

ality

12 years, 3 months ago (2013-01-19 03:01:09 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=845f6e3bb306 ***

cmd/6c, cmd/8c: fix print format for Prog

The FmtLong flag should only be used with the %D verb
when printing an ATEXT Prog. It was erroneously used
for every Prog except ADATA. This caused a preponderance
of exclamation points, "!!", in the assembly listings.

I also cleaned up the code so that the list.c files look
very similar. Now the real differences are easily spotted
with a simple diff.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7128045

Expand All Messages | Collapse All Messages