code review 7105047: net/http/cgi: fix test case sensitivity on Windows

net/http/cgi: fix test case sensitivity on Windows

Fixes issue 4645

[bradfitz, 2013-01-11 21:59:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2013-01-11 22:16:37]

LGTM

[minux1, 2013-01-11 22:26:10]

https://codereview.appspot.com/7105047/diff/4001/src/pkg/net/http/cgi/host_te...
File src/pkg/net/http/cgi/host_test.go (right):

https://codereview.appspot.com/7105047/diff/4001/src/pkg/net/http/cgi/host_te...
src/pkg/net/http/cgi/host_test.go:69: got, expected = strings.ToLower(got),
strings.ToLower(expected)
can we use os.SameFile for this?
I think it will be more portable.

[brainman, 2013-01-11 22:35:17]

> can we use os.SameFile for this?
> I think it will be more portable.

It might work :-) 

Alex

[bradfitz, 2013-01-11 22:45:36]

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com, minux.ma@gmail.com
(cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-01-11 22:45:54]

PTAL, now with overengineering for Windows.

On Fri, Jan 11, 2013 at 2:35 PM, <alex.brainman@gmail.com> wrote:

> can we use os.SameFile for this?
>> I think it will be more portable.
>>
>
> It might work :-)
>
> Alex
>
>
https://codereview.appspot.**com/7105047/<https://codereview.appspot.com/7105...
>

[minux1, 2013-01-11 22:50:06]

https://codereview.appspot.com/7105047/diff/9001/src/pkg/net/http/cgi/host_te...
File src/pkg/net/http/cgi/host_test.go (right):

https://codereview.appspot.com/7105047/diff/9001/src/pkg/net/http/cgi/host_te...
src/pkg/net/http/cgi/host_test.go:74: got, expected = strings.ToLower(got),
strings.ToLower(expected)
i think this is unnecessary.
if fi1 and fi2 are not the same file/directory, then
the test should definitely fail.

[bradfitz, 2013-01-11 22:51:45]

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com, minux.ma@gmail.com
(cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-01-11 22:51:52]

https://codereview.appspot.com/7105047/diff/9001/src/pkg/net/http/cgi/host_te...
File src/pkg/net/http/cgi/host_test.go (right):

https://codereview.appspot.com/7105047/diff/9001/src/pkg/net/http/cgi/host_te...
src/pkg/net/http/cgi/host_test.go:74: got, expected = strings.ToLower(got),
strings.ToLower(expected)
On 2013/01/11 22:50:06, minux wrote:
> i think this is unnecessary.
> if fi1 and fi2 are not the same file/directory, then
> the test should definitely fail.

Most boring CL ever.

Done.

[minux1, 2013-01-11 22:59:41]

LGTM, but I can't test it atm so please wait for Alex.

[minux1, 2013-01-11 23:06:56]

On Sat, Jan 12, 2013 at 6:51 AM, <bradfitz@golang.org> wrote:

> Most boring CL ever.
>
sorry about that. I just thought symlinks might also affect this test
so os.SameFile is a bit safer, just in case.

[brainman, 2013-01-11 23:09:04]

On 2013/01/11 22:59:41, minux wrote:
> LGTM, but I can't test it atm so please wait for Alex.

I think brad is overdoing it :-). I have no computer to test it now. But LGTM. I
will fix it, if it breaks.

Alex

[bradfitz, 2013-01-11 23:09:45]

On Fri, Jan 11, 2013 at 3:09 PM, <alex.brainman@gmail.com> wrote:

> On 2013/01/11 22:59:41, minux wrote:
>
>> LGTM, but I can't test it atm so please wait for Alex.
>>
>
> I think brad is overdoing it :-)


Hey, I started with strings.ToLower.  You guys wanted SameFile.  :-)

[bradfitz, 2013-01-11 23:11:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=1b4a28e7f042 ***

net/http/cgi: fix test case sensitivity on Windows

Fixes issue 4645

R=golang-dev, alex.brainman, minux.ma
CC=golang-dev
https://codereview.appspot.com/7105047