Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 7100049: code review 7100049: encoding/json: fix panics on type mismatches. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by remyoudompheng
Modified:
11 years, 2 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

encoding/json: fix panics on type mismatches. Fixes issue 4222. Fixes issue 4628.

Patch Set 1 #

Patch Set 2 : diff -r e088d9c306df https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e088d9c306df https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4e888cb82eac https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M src/pkg/encoding/json/decode.go View 1 6 chunks +24 lines, -10 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 2 months ago (2013-01-12 08:16:10 UTC) #1
adg
LGTM Nice.
11 years, 2 months ago (2013-01-14 00:34:56 UTC) #2
remyoudompheng
11 years, 2 months ago (2013-01-14 07:44:50 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=c3b05ada7ea5 ***

encoding/json: fix panics on type mismatches.

Fixes issue 4222.
Fixes issue 4628.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7100049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b