Issue 7099045: net/http: make redirect handlers from mux.Handler() not...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7099045: net/http: make redirect handlers from mux.Handler() not... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by minux1

Modified:
10 years, 8 months ago

Reviewers:
adg, Hierro, bradfitz

CC:
bradfitz, Hierro, rsc, adg, golang-dev

Visibility:
Public.

Description

net/http: redirect handlers from mux.Handler() shouldn't clear the query string

Patch Set 1 #

Patch Set 2 : diff -r fc9545bf5a1f https://code.google.com/p/go #

Patch Set 3 : diff -r fc9545bf5a1f https://code.google.com/p/go #

Patch Set 4 : diff -r b27b1ff18f39 https://code.google.com/p/go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -1 line)			Patch
	M	src/pkg/net/http/server.go	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
	M	src/pkg/net/http/server_test.go	View	1 2	3 chunks	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

LGTM But the test seems way bigger than I would've expected. On Fri, Aug 2, ...

10 years, 9 months ago (2013-08-02 17:22:49 UTC) #2

bradfitz

10 years, 8 months ago (2013-08-29 20:55:12 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b27e215d7387 ***

net/http: redirect handlers from mux.Handler() shouldn't clear the query string

R=bradfitz, alberto.garcia.hierro, rsc, adg
CC=golang-dev
https://codereview.appspot.com/7099045

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages