Issue 7098071: code review 7098071: go.talks/present: Only pull in play.js if play is enabled.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7098071: code review 7098071: go.talks/present: Only pull in play.js if play is enabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dsymonds

Modified:
11 years, 3 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

go.talks/present: Only pull in play.js if play is enabled.

Patch Set 1 #

Patch Set 2 : diff -r 552e6c5d1ca3 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 552e6c5d1ca3 https://code.google.com/p/go.talks #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	pkg/present/parse.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	present/templates/slides.tmpl	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dsymonds

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 3 months ago (2013-01-21 05:58:41 UTC) #1

dsymonds

I noticed this when doing an edit-save-reload cycle. The terminal running present gets a flood ...

11 years, 3 months ago (2013-01-21 06:10:31 UTC) #2

dsymonds

11 years, 3 months ago (2013-01-21 08:02:48 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=af545e29be48&repo=talks ***

go.talks/present: Only pull in play.js if play is enabled.

R=adg
CC=golang-dev
https://codereview.appspot.com/7098071

Expand All Messages | Collapse All Messages