Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2433)

Issue 7098046: code review 7098046: test: adapt old-style tests to new flag parsing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by remyoudompheng
Modified:
12 years, 2 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

test: adapt old-style tests to new flag parsing. The -I. syntax now needs a space to be recognized in the compiler.

Patch Set 1 #

Patch Set 2 : diff -r 6c39cb75b6ee https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6c39cb75b6ee https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 619087095cf9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/safe/nousesafe.go View 1 1 chunk +1 line, -1 line 0 comments Download
M test/safe/usesafe.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2013-01-11 20:57:46 UTC) #1
bradfitz
LGTM On Fri, Jan 11, 2013 at 12:57 PM, <remyoudompheng@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
12 years, 2 months ago (2013-01-11 21:03:22 UTC) #2
remyoudompheng
12 years, 2 months ago (2013-01-11 21:05:59 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=886debcfcd43 ***

test: adapt old-style tests to new flag parsing.

The -I. syntax now needs a space to be recognized in the
compiler.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7098046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b