Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(347)

Issue 7094062: code review 7094062: doc/go_spec: cap doesn't apply to maps (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by minux1
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, adg, dave_cheney.net
Visibility:
Public.

Description

doc/go_spec: cap doesn't apply to maps Fixes issue 4682.

Patch Set 1 #

Patch Set 2 : diff -r 7dc8d66efb6d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7dc8d66efb6d https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 7dc8d66efb6d https://code.google.com/p/go/ #

Patch Set 5 : diff -r 119bec1258fc https://code.google.com/p/go/ #

Patch Set 6 : diff -r 119bec1258fc https://code.google.com/p/go/ #

Patch Set 7 : diff -r 119bec1258fc https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M doc/go_spec.html View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 1 month ago (2013-01-21 04:50:01 UTC) #1
adg
LGTM
12 years, 1 month ago (2013-01-21 05:05:30 UTC) #2
dave_cheney.net
https://codereview.appspot.com/7094062/diff/5001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7094062/diff/5001/doc/go_spec.html#newcode4925 doc/go_spec.html:4925: The length and capacity of a <code>nil</code> slice or ...
12 years, 1 month ago (2013-01-21 05:06:28 UTC) #3
adg
On 21 January 2013 16:06, <dave@cheney.net> wrote: > The length of a <code>nil</code> slice, map, ...
12 years, 1 month ago (2013-01-21 05:12:44 UTC) #4
minux1
PTAL. On 2013/01/21 05:12:44, adg wrote: > On 21 January 2013 16:06, <mailto:dave@cheney.net> wrote: > ...
12 years, 1 month ago (2013-01-21 05:27:58 UTC) #5
dave_cheney.net
LGTM. Thanks for fixing this so quickly.
12 years, 1 month ago (2013-01-21 05:29:15 UTC) #6
minux1
12 years, 1 month ago (2013-01-21 19:18:33 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=073d912321cc ***

doc/go_spec: cap doesn't apply to maps
Fixes issue 4682.

R=golang-dev, adg, dave
CC=golang-dev
https://codereview.appspot.com/7094062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b