Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 7085048: code review 7085048: os: use SameFile in TestStartProcess (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by minux1
Modified:
11 years, 2 months ago
Reviewers:
CC:
golang-dev, bradfitz, brainman
Visibility:
Public.

Description

os: use SameFile in TestStartProcess Fixes issue 4650.

Patch Set 1 #

Patch Set 2 : diff -r fc9545bf5a1f https://code.google.com/p/go #

Patch Set 3 : diff -r fc9545bf5a1f https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r fc9545bf5a1f https://code.google.com/p/go #

Patch Set 5 : diff -r fc9545bf5a1f https://code.google.com/p/go #

Patch Set 6 : diff -r d67c54bb524e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/pkg/os/os_test.go View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2013-01-11 23:58:04 UTC) #1
bradfitz
LGTM but see comment https://codereview.appspot.com/7085048/diff/5001/src/pkg/os/os_test.go File src/pkg/os/os_test.go (right): https://codereview.appspot.com/7085048/diff/5001/src/pkg/os/os_test.go#newcode540 src/pkg/os/os_test.go:540: fi1, _ := Stat(strings.TrimRight(output, trailing)) ...
11 years, 2 months ago (2013-01-12 00:04:56 UTC) #2
minux1
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2013-01-12 00:05:09 UTC) #3
minux1
I remove the use of strings.TrimRight because it can't differentiate between "line\r\n" and "line\r\n\r\n".
11 years, 2 months ago (2013-01-12 00:06:40 UTC) #4
bradfitz
LGTM do we care about the exactly trailing whitespace? Seems like strings.TrimSpace is good enough. ...
11 years, 2 months ago (2013-01-12 00:09:25 UTC) #5
minux1
I get rid of variable le and parameter trailing in code and uses strings.TrimSpace, now ...
11 years, 2 months ago (2013-01-12 00:20:39 UTC) #6
bradfitz
LGTM
11 years, 2 months ago (2013-01-12 00:36:45 UTC) #7
brainman
LGTM Today is os.SameFile day. Alex
11 years, 2 months ago (2013-01-12 02:45:58 UTC) #8
minux1
11 years, 2 months ago (2013-01-17 10:48:26 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=4d18f52cad80 ***

os: use SameFile in TestStartProcess
Fixes issue 4650.

R=golang-dev, bradfitz, alex.brainman
CC=golang-dev
https://codereview.appspot.com/7085048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b