Issue 7082044: code review 7082044: text/template: Document that range can be used on chan ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7082044: code review 7082044: text/template: Document that range can be used on chan ...

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by kisielk

Modified:
11 years, 3 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

text/template: Document that range can be used on chan types. Fixes issue 4640.

Patch Set 2 : diff -r d96fe1298b88 https://code.google.com/p/go #

Patch Set 3 : diff -r d96fe1298b88 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r d96fe1298b88 https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/text/template/doc.go	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kisielk

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2013-01-10 23:41:14 UTC) #1

adg

https://codereview.appspot.com/7082044/diff/4002/src/pkg/text/template/doc.go File src/pkg/text/template/doc.go (right): https://codereview.appspot.com/7082044/diff/4002/src/pkg/text/template/doc.go#newcode66 src/pkg/text/template/doc.go:66: The value of the pipeline must be an array, ...

11 years, 3 months ago (2013-01-11 11:47:34 UTC) #2

kisielk

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 3 months ago (2013-01-11 17:38:30 UTC) #3

adg

11 years, 3 months ago (2013-01-12 00:06:20 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=76f4eb620983 ***

text/template: Document that range can be used on chan types.

Fixes issue 4640.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7082044

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages