Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 70710043: code review 70710043: cmd/ld: don't include padding length in size of the not... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by minux1
Modified:
11 years ago
Reviewers:
gobot, rsc, iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

cmd/ld: don't include padding length in size of the note section Recently NetBSD starts to enforce this, and refuses to execute the program if n is larger than the sum of entry sizes. Before: $ readelf -n ../bin/go.old Notes at offset 0x00000bd0 with length 0x00000019: Owner Data size Description NetBSD 0x00000004 NT_VERSION (version) readelf: Warning: corrupt note found at offset 18 into core notes readelf: Warning: type: 0, namesize: 00000000, descsize: 00000000 $ readelf -n ../bin/go Notes at offset 0x00000bd0 with length 0x00000018: Owner Data size Description NetBSD 0x00000004 NT_VERSION (version)

Patch Set 1 #

Patch Set 2 : diff -r 63f448126b28 https://code.google.com/p/go #

Patch Set 3 : diff -r 63f448126b28 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 7257b771f12b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/ld/elf.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
minux1
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years ago (2014-03-03 08:02:39 UTC) #1
iant
https://codereview.appspot.com/70710043/diff/40001/src/cmd/ld/elf.c File src/cmd/ld/elf.c (right): https://codereview.appspot.com/70710043/diff/40001/src/cmd/ld/elf.c#newcode358 src/cmd/ld/elf.c:358: sh->size = n & ~3; I think this will ...
11 years ago (2014-03-03 15:44:00 UTC) #2
minux1
https://codereview.appspot.com/70710043/diff/40001/src/cmd/ld/elf.c File src/cmd/ld/elf.c (right): https://codereview.appspot.com/70710043/diff/40001/src/cmd/ld/elf.c#newcode358 src/cmd/ld/elf.c:358: sh->size = n & ~3; On 2014/03/03 15:44:00, iant ...
11 years ago (2014-03-03 21:10:05 UTC) #3
minux1
PTAL.
11 years ago (2014-03-03 21:12:04 UTC) #4
iant
LGTM
11 years ago (2014-03-03 22:13:32 UTC) #5
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=db613ec83949 *** cmd/ld: don't include padding length in size of the note ...
11 years ago (2014-03-05 19:40:58 UTC) #6
gobot
This CL appears to have broken the plan9-386-cnielsen builder.
11 years ago (2014-03-06 05:19:58 UTC) #7
minux1
11 years ago (2014-03-06 05:23:19 UTC) #8
On Thu, Mar 6, 2014 at 12:19 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the plan9-386-cnielsen builder.
>
# ../misc/goplay

# ../test/bench/go1
ok   _/tmp/gobuilder/plan9-386-cnielsen-db613ec83949/go/test/bench/go1
16.145s

# ../test
Build complete, duration 1h0m0.125292928s. Result: error: timed out after
1h0m0s


Shouldn't be related to this change.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b