Issue 7070048: code review 7070048: spec: s/char_lit/rune_lit/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7070048: code review 7070048: spec: s/char_lit/rune_lit/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by gri

Modified:
12 years, 2 months ago

Reviewers:

CC:
rsc, iant, r, ken2, golang-dev

Visibility:
Public.

Description

spec: s/char_lit/rune_lit/ The spec talks explicitly about rune literals but the respective production is still called char_lit for historic reasons. Updated the two occurences. Fixes issue 4602.

Patch Set 1 #

Patch Set 2 : diff -r 8906cf341c9b https://code.google.com/p/go #

Patch Set 3 : diff -r 8906cf341c9b https://code.google.com/p/go #

Patch Set 4 : diff -r 66b0356aa14c https://code.google.com/p/go #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	doc/go_spec.html	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org, iant@golang.org, r@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...

12 years, 2 months ago (2013-01-07 19:20:37 UTC) #1

gri

12 years, 2 months ago (2013-01-08 02:03:27 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=43203aa69a8a ***

spec: s/char_lit/rune_lit/

The spec talks explicitly about rune literals but the
respective production is still called char_lit for
historic reasons. Updated the two occurences.

Fixes issue 4602.

R=rsc, iant, r, ken
CC=golang-dev
https://codereview.appspot.com/7070048

Expand All Messages | Collapse All Messages