Issue 7069045: code review 7069045: image/jpeg: handle those (unusual) grayscale images who...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7069045: code review 7069045: image/jpeg: handle those (unusual) grayscale images who... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by nigeltao

Modified:
11 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

image/jpeg: handle those (unusual) grayscale images whose sampling ratio isn't 1x1. Fixes issue 4259. The test data was generated by cjpeg -quality 50 -sample 2x2 video-005.gray.pgm > video-005.gray.q50.2x2.jpeg cjpeg -quality 50 -sample 2x2 -progressive video-005.gray.pgm > video-005.gray.q50.2x2.progressive.jpeg similarly to video-005.gray.q50.* from http://code.google.com/p/go/source/detail?r=51f26e36ba98 the key difference being the "-sample 2x2".

Patch Set 1 #

Patch Set 2 : diff -r c9c7020ebc87 https://code.google.com/p/go #

Patch Set 3 : diff -r c9c7020ebc87 https://code.google.com/p/go #

Patch Set 4 : diff -r 49db9317937c https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -5 lines)			Patch
M	src/pkg/image/jpeg/reader.go	View	1	1 chunk	+18 lines, -5 lines	0 comments	Download
M	src/pkg/image/jpeg/reader_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/image/testdata/video-005.gray.q50.2x2.jpeg	View	1	Binary file		0 comments	Download
A	src/pkg/image/testdata/video-005.gray.q50.2x2.progressive.jpeg	View	1	Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2013-01-07 04:45:15 UTC) #1

nigeltao

11 years, 3 months ago (2013-01-07 05:16:42 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=29fab86e961e ***

image/jpeg: handle those (unusual) grayscale images whose sampling
ratio isn't 1x1.

Fixes issue 4259.

The test data was generated by
cjpeg -quality 50 -sample 2x2 video-005.gray.pgm > video-005.gray.q50.2x2.jpeg
cjpeg -quality 50 -sample 2x2 -progressive video-005.gray.pgm >
video-005.gray.q50.2x2.progressive.jpeg

similarly to video-005.gray.q50.* from
http://code.google.com/p/go/source/detail?r=51f26e36ba98
the key difference being the "-sample 2x2".

R=rsc
CC=golang-dev
https://codereview.appspot.com/7069045

Expand All Messages | Collapse All Messages