Issue 70650043: code review 70650043: go1.2.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 70650043: code review 70650043: go1.2.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by adg

Modified:
10 years, 1 month ago

Reviewers:
minux1

CC:
minux1, r, golang-codereviews

Visibility:
Public.

Description

go1.2.1

Patch Set 1 #

Patch Set 2 : diff -r 66253be6d673 https://code.google.com/p/go #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	VERSION	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello minux, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 1 month ago (2014-03-03 00:34:42 UTC) #1

gobot

Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...

10 years, 1 month ago (2014-03-03 00:38:21 UTC) #2

adg

On 3 March 2014 11:39, minux <minux.ma@gmail.com> wrote: > PS: please submit this after the ...

10 years, 1 month ago (2014-03-03 00:43:20 UTC) #4

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=0ddbdc3c7ce2 *** go1.2.1 R=minux.ma, r CC=golang-codereviews, golang-dev https://codereview.appspot.com/70650043

10 years, 1 month ago (2014-03-03 00:53:04 UTC) #5

gobot

10 years, 1 month ago (2014-03-03 00:54:03 UTC) #6

Message was sent while issue was closed.

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

Expand All Messages | Collapse All Messages