Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1741)

Issue 7064067: code review 7064067: test: make rundir match compiledir/errorcheckdir. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by remyoudompheng
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, bradfitz, iant
Visibility:
Public.

Description

test: make rundir match compiledir/errorcheckdir. This allows test/dwarf to be supported by run.go. Update issue 4139.

Patch Set 1 #

Patch Set 2 : diff -r 6c39cb75b6ee https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6c39cb75b6ee https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fc9545bf5a1f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
A test/dwarf/dwarf.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
M test/dwarf/dwarf.dir/main.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z1.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z10.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z11.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z12.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z13.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z14.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z15.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z16.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z17.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z18.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z19.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z2.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z20.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z3.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z4.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z5.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z6.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z7.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z8.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/dwarf/dwarf.dir/z9.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M test/run.go View 1 4 chunks +20 lines, -40 lines 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 4 months ago (2013-01-10 18:54:33 UTC) #1
bradfitz
LGTM
11 years, 4 months ago (2013-01-10 20:31:50 UTC) #2
iant
Make sure "bash ./run" in the test directory still works and still runs the test.
11 years, 4 months ago (2013-01-10 20:37:19 UTC) #3
remyoudompheng
On 2013/01/10 20:37:19, iant wrote: > Make sure "bash ./run" in the test directory still ...
11 years, 4 months ago (2013-01-11 21:00:06 UTC) #4
remyoudompheng
11 years, 4 months ago (2013-01-11 21:02:18 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=619087095cf9 ***

test: make rundir match compiledir/errorcheckdir.

This allows test/dwarf to be supported by run.go.

Update issue 4139.

R=golang-dev, bradfitz, iant
CC=golang-dev
https://codereview.appspot.com/7064067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b