Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 7064045: code review 7064045: encoding/json: documented that ,string applies only to ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by cespare
Modified:
11 years, 2 months ago
Reviewers:
CC:
golang-dev, adg, rsc
Visibility:
Public.

Description

encoding/json: documented that ,string applies only to string and numeric fields. Fixes issue 4437.

Patch Set 1 #

Patch Set 2 : diff -r 8bbc0bdf832e https://code.google.com/p/go #

Patch Set 3 : diff -r 8bbc0bdf832e https://code.google.com/p/go #

Total comments: 3

Patch Set 4 : diff -r 12562bcfba22 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/encoding/json/encode.go View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8
cespare
Hello golang-dev@googlegroups.com (cc: rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2013-01-05 03:28:07 UTC) #1
adg
https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go File src/pkg/encoding/json/encode.go (right): https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go#newcode78 src/pkg/encoding/json/encode.go:78: // JSON-encoded string. It applies only to fields with ...
11 years, 2 months ago (2013-01-06 21:33:17 UTC) #2
cespare
On 2013/01/06 21:33:17, adg wrote: > https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go > File src/pkg/encoding/json/encode.go (right): > > https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go#newcode78 > ...
11 years, 2 months ago (2013-01-06 21:39:53 UTC) #3
adg
On 7 January 2013 08:39, <cespare@gmail.com> wrote: > It puts a string inside an extra ...
11 years, 2 months ago (2013-01-06 21:51:46 UTC) #4
adg
https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go File src/pkg/encoding/json/encode.go (right): https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go#newcode78 src/pkg/encoding/json/encode.go:78: // JSON-encoded string. It applies only to fields with ...
11 years, 2 months ago (2013-01-06 21:51:58 UTC) #5
cespare
PTAL https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go File src/pkg/encoding/json/encode.go (right): https://codereview.appspot.com/7064045/diff/3002/src/pkg/encoding/json/encode.go#newcode78 src/pkg/encoding/json/encode.go:78: // JSON-encoded string. It applies only to fields ...
11 years, 2 months ago (2013-01-06 22:16:20 UTC) #6
adg
LGTM
11 years, 2 months ago (2013-01-06 22:39:05 UTC) #7
adg
11 years, 2 months ago (2013-01-06 22:44:54 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=63223d237fd8 ***

encoding/json: documented that ,string applies only to string and numeric
fields.

Fixes issue 4437.

R=golang-dev, adg
CC=golang-dev, rsc
https://codereview.appspot.com/7064045

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b