Issue 7062049: code review 7062049: doc: fix effective_go: s/byte array/byte slice/.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7062049: code review 7062049: doc: fix effective_go: s/byte array/byte slice/. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by nigeltao

Modified:
12 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev, mdempsky

Visibility:
Public.

Description

doc: fix effective_go: s/byte array/byte slice/.

Patch Set 2 : diff -r c9c7020ebc87 https://code.google.com/p/go #

Patch Set 3 : diff -r c9c7020ebc87 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 8516cee2bf33 https://code.google.com/p/go #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	doc/effective_go.html	View	1 2 3	8 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, mdempsky@google.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 2 months ago (2013-01-07 00:21:42 UTC) #1

rsc

LGTM https://codereview.appspot.com/7062049/diff/2002/doc/effective_go.html File doc/effective_go.html (right): https://codereview.appspot.com/7062049/diff/2002/doc/effective_go.html#newcode2940 doc/effective_go.html:2940: as a slice index out of bounds, the ...

12 years, 2 months ago (2013-01-18 20:06:28 UTC) #2

nigeltao

12 years, 2 months ago (2013-01-19 02:37:18 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6287072632c4 ***

doc: fix effective_go: s/byte array/byte slice/.

R=rsc
CC=golang-dev, mdempsky
https://codereview.appspot.com/7062049

Expand All Messages | Collapse All Messages