code review 7057048: go/doc: trim only first space or newline from example o...

go/doc: trim only first space or newline from example output comment

Fixes issue 4487.

[adg, 2013-01-07 02:18:19]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-01-07 02:25:54]

LGTM

Make it 'zero or more spaces followed by \n or a single space'.

[adg, 2013-01-07 02:44:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=94f0ce1a6b70 ***

go/doc: trim only first space or newline from example output comment

Fixes issue 4487.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7057048

[adg, 2013-01-07 02:47:47]

On 7 January 2013 13:44, <adg@golang.org> wrote:

> go/doc: trim only first space or newline from example output comment


Damn. I forgot to update the change description. The comment and code was
updated, though.

[rsc, 2013-01-07 03:42:08]

The code looks like it strips all leading spaces up to the first
non-space, eating the \n if that's the non-space. That's fine too.

[adg, 2013-01-07 03:51:40]

On 7 January 2013 14:42, Russ Cox <rsc@golang.org> wrote:

> The code looks like it strips all leading spaces up to the first
> non-space, eating the \n if that's the non-space.
>

And equivalent to the wording you suggested, right?

[rsc, 2013-01-07 03:53:11]

I was suggesting / | +\n/ but you did / *\n?/. Yours is probably better.