Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129)

Issue 70490043: code review 70490043: runtime: make SIGSYS notifiable on FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by mikio
Modified:
10 years ago
Reviewers:
gobot, dfc, iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

runtime: make SIGSYS notifiable on FreeBSD Update issue 7186

Patch Set 1 : diff -r 5db1072ebd76 https://code.google.com/p/go #

Patch Set 2 : diff -r 5db1072ebd76 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/signals_freebsd.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
mikio
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years ago (2014-03-02 09:14:56 UTC) #1
iant
LGTM
10 years ago (2014-03-02 19:15:02 UTC) #2
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=17d3b45534b5 *** runtime: make SIGSYS notifiable on FreeBSD Update issue 7186 LGTM=iant ...
10 years ago (2014-03-02 22:08:55 UTC) #3
gobot
This CL appears to have broken the linux-arm-cheney-panda builder.
10 years ago (2014-03-02 22:54:30 UTC) #4
dfc
Finalizers are still unstable on arm, wasn't this supposed to be fixed ? # sync ...
10 years ago (2014-03-03 04:25:44 UTC) #5
mikio
On Mon, Mar 3, 2014 at 1:25 PM, Dave Cheney <dave@cheney.net> wrote: > Finalizers are ...
10 years ago (2014-03-03 04:30:24 UTC) #6
dfc
Sorry, I didn't mean that your CL was going to fix finalisers. However I did ...
10 years ago (2014-03-03 04:31:15 UTC) #7
mikio
On Mon, Mar 3, 2014 at 1:31 PM, Dave Cheney <dave@cheney.net> wrote: > Sorry, I ...
10 years ago (2014-03-03 04:51:54 UTC) #8
dfc
10 years ago (2014-03-03 04:53:08 UTC) #9
Absolutely. Please consider my comments unrelated to your CL.


On Mon, Mar 3, 2014 at 3:51 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> On Mon, Mar 3, 2014 at 1:31 PM, Dave Cheney <dave@cheney.net> wrote:
>
> > Sorry, I didn't mean that your CL was going to fix finalisers. However I
> did
> > think that recent commits by Dmitry and khr resolved the issue.
>
> i see, but the goal is 3months away...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b