Issue 7037047: code review 7037047: go.talks/pkg/present: add iframe command

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7037047: code review 7037047: go.talks/pkg/present: add iframe command (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by adg

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

go.talks/pkg/present: add iframe command

Patch Set 1 #

Patch Set 2 : diff -r 7aeec2e4d13b https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 7aeec2e4d13b https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 7aeec2e4d13b https://code.google.com/p/go.talks #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
M	pkg/present/doc.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	pkg/present/iframe.go	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	present/templates/action.tmpl	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 4 months ago (2013-01-03 10:15:45 UTC) #1

rsc

LGTM I thought iframes were deprecated, but what do I know...

11 years, 4 months ago (2013-01-04 15:30:55 UTC) #2

adg

On 5 January 2013 02:30, Russ Cox <rsc@golang.org> wrote: > I thought iframes were deprecated, ...

11 years, 4 months ago (2013-01-06 01:59:06 UTC) #3

adg

11 years, 4 months ago (2013-01-06 01:59:28 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=3e528b1bc474&repo=talks ***

go.talks/pkg/present: add iframe command

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7037047

Expand All Messages | Collapse All Messages