Issue 7027049: code review 7027049: spec: Use "non-negative" instead of "positive"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7027049: code review 7027049: spec: Use "non-negative" instead of "positive" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by mdempsky

Modified:
12 years, 2 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

spec: Use "non-negative" instead of "positive" Replacing division-by-power-of-2 with right-shift is valid for zero too.

Patch Set 2 : diff -r 6e941dd4ded3 https://code.google.com/p/go #

Patch Set 3 : diff -r 6e941dd4ded3 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r f0e7ba409b05 https://code.google.com/p/go #

Patch Set 5 : diff -r d0d76b7fb219 https://code.google.com/p/go #

Patch Set 6 : diff -r ae4e014e0b77 https://code.google.com/p/go #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	doc/go_spec.html	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

mdempsky

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 2 months ago (2013-01-03 00:19:31 UTC) #1

nigeltao

https://codereview.appspot.com/7027049/diff/6001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7027049/diff/6001/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": "Version of December 12, 2012", Please update this ...

12 years, 2 months ago (2013-01-03 03:18:28 UTC) #2

mdempsky

Hello golang-dev@googlegroups.com, nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 2 months ago (2013-01-03 03:23:30 UTC) #3

mdempsky

It looks like in the mean time Robert Griesemer also updated the spec today and ...

12 years, 2 months ago (2013-01-03 03:28:17 UTC) #4

gri

12 years, 2 months ago (2013-01-07 00:56:45 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=722de23e5fc9 ***

spec: Use "non-negative" instead of "positive"

Replacing division-by-power-of-2 with right-shift is valid for
zero too.

R=gri
CC=golang-dev
https://codereview.appspot.com/7027049

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages