Issue 70200053: code review 70200053: cmd/gc: fix internal crash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 70200053: code review 70200053: cmd/gc: fix internal crash (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by rsc

Modified:
10 years, 1 month ago

Reviewers:
gobot, ken3

CC:
ken2, golang-codereviews

Visibility:
Public.

Description

cmd/gc: fix internal crash

Patch Set 1 #

Patch Set 2 : diff -r 99ea54506ebb https://code.google.com/p/go/ #

Patch Set 3 : diff -r 99ea54506ebb https://code.google.com/p/go/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	src/cmd/gc/typecheck.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	A	test/fixedbugs/issue7310.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 1 month ago (2014-03-04 00:55:38 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=2750cd9fc49b *** cmd/gc: fix internal crash TBR=ken2 CC=golang-codereviews https://codereview.appspot.com/70200053

10 years, 1 month ago (2014-03-04 00:55:43 UTC) #2

ken3

On 2014/03/04 00:55:43, rsc wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=2750cd9fc49b *** > > cmd/gc: fix ...

10 years, 1 month ago (2014-03-04 00:57:37 UTC) #3

gobot

10 years, 1 month ago (2014-03-04 02:12:30 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-arm-cheney-panda builder.

Expand All Messages | Collapse All Messages