Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(416)

Issue 70190046: code review 70190046: go/parser: better error position for non-invoked gp/def... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by gri
Modified:
11 years ago
Reviewers:
gobot, bradfitz
CC:
bradfitz, golang-codereviews
Visibility:
Public.

Description

go/parser: better error position for non-invoked gp/defer functions Added test cases and expanded test harness to handle token end positions. Also: Make sure token end positions are never outside the valid position range, as was possible in case of parse errors. Fixes issue 7458.

Patch Set 1 #

Patch Set 2 : diff -r 363a4ef7e011 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8f8ae5044f24 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8f8ae5044f24 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 5 : diff -r 8f8ae5044f24 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -13 lines) Patch
M src/pkg/go/parser/error_test.go View 1 2 3 4 3 chunks +18 lines, -3 lines 0 comments Download
M src/pkg/go/parser/parser.go View 1 2 3 4 10 chunks +30 lines, -10 lines 0 comments Download
M src/pkg/go/parser/short_test.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
gri
Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years ago (2014-03-04 22:01:34 UTC) #1
bradfitz
LGTM Thanks! https://codereview.appspot.com/70190046/diff/60001/src/pkg/go/parser/error_test.go File src/pkg/go/parser/error_test.go (right): https://codereview.appspot.com/70190046/diff/60001/src/pkg/go/parser/error_test.go#newcode66 src/pkg/go/parser/error_test.go:66: var errRx = regexp.MustCompile(`^/\* *ERROR *(HERE|) *"([^"]*)" ...
11 years ago (2014-03-04 22:06:45 UTC) #2
gri
https://codereview.appspot.com/70190046/diff/60001/src/pkg/go/parser/error_test.go File src/pkg/go/parser/error_test.go (right): https://codereview.appspot.com/70190046/diff/60001/src/pkg/go/parser/error_test.go#newcode66 src/pkg/go/parser/error_test.go:66: var errRx = regexp.MustCompile(`^/\* *ERROR *(HERE|) *"([^"]*)" *\*/$`) On ...
11 years ago (2014-03-04 22:10:30 UTC) #3
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=72b9500c86ce *** go/parser: better error position for non-invoked gp/defer functions Added test ...
11 years ago (2014-03-04 22:10:41 UTC) #4
gobot
11 years ago (2014-03-04 22:40:37 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the windows-386-ec2 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b