Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3415)

Issue 70140043: code review 70140043: os: don't allow Process.Kill after Process.Release (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by bradfitz
Modified:
10 years, 1 month ago
Reviewers:
gobot, iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

os: don't allow Process.Kill after Process.Release This is a user error, but killing -1 kills everything, which is a pretty bad failure mode. Fixes Issue 7434

Patch Set 1 #

Patch Set 2 : diff -r d9a3ecc457c5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d9a3ecc457c5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d9a3ecc457c5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/pkg/os/exec_unix.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 1 month ago (2014-02-28 16:14:22 UTC) #1
iant
LGTM although it's less amusing.
10 years, 1 month ago (2014-02-28 16:29:37 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=11019c720b58 *** os: don't allow Process.Kill after Process.Release This is a user ...
10 years, 1 month ago (2014-02-28 16:31:14 UTC) #3
gobot
10 years, 1 month ago (2014-02-28 16:44:58 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the windows-386-ec2 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b