Issue 7005049: code review 7005049: net/http: match curl and others' NO_PROXY wildcard handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7005049: code review 7005049: net/http: match curl and others' NO_PROXY wildcard handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bradfitz

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/http: match curl and others' NO_PROXY wildcard handling NO_PROXY="example.com" should match "foo.example.com", just the same as NO_PROXY=".example.com". This is what curl and Python do. Fixes issue 4574

Patch Set 1 #

Patch Set 2 : diff -r 791d6c690c0e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 791d6c690c0e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5f9e99e3f2ea https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -17 lines)			Patch
M	src/pkg/net/http/proxy_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/transport.go	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	src/pkg/net/http/transport_test.go	View	1	2 chunks	+45 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-12-21 22:34:25 UTC) #1

bradfitz

11 years, 5 months ago (2012-12-23 01:41:07 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=87f67aadaed6 ***

net/http: match curl and others' NO_PROXY wildcard handling

NO_PROXY="example.com" should match "foo.example.com", just
the same as NO_PROXY=".example.com".  This is what curl and
Python do.

Fixes issue 4574

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7005049

Expand All Messages | Collapse All Messages