Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 7002044: code review 7002044: go.talks/pkg/present: match headings precisely (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by adg
Modified:
11 years, 5 months ago
Reviewers:
CC:
campoy, francesc, golang-dev
Visibility:
Public.

Description

go.talks/pkg/present: match headings precisely Previously, if you began a line with a bold word, like *Note:* something important. the parser would think it was the beginning of a top-level section. Now it doesn't.

Patch Set 1 #

Patch Set 2 : diff -r 90aeb3fdd6ea https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 90aeb3fdd6ea https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M pkg/present/parse.go View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3
adg
Hello campoy (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
11 years, 5 months ago (2012-12-21 00:25:20 UTC) #1
francesc
On 2012/12/21 00:25:20, adg wrote: > Hello campoy (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
11 years, 5 months ago (2012-12-21 01:25:32 UTC) #2
adg
11 years, 5 months ago (2012-12-21 01:30:09 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=7aeec2e4d13b&repo=talks ***

go.talks/pkg/present: match headings precisely

Previously, if you began a line with a bold word, like
        *Note:* something important.
the parser would think it was the beginning of a top-level section.

Now it doesn't.

R=campoy, campoy
CC=golang-dev
https://codereview.appspot.com/7002044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b