Issue 7001051: code review 7001051: runtime: aggregate defer allocations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7001051: code review 7001051: runtime: aggregate defer allocations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:
ken3, dave

CC:
ken2, golang-dev

Visibility:
Public.

Description

runtime: aggregate defer allocations benchmark old ns/op new ns/op delta BenchmarkDefer 165 113 -31.52% BenchmarkDefer10 155 103 -33.55% BenchmarkDeferMany 216 158 -26.85% benchmark old allocs new allocs delta BenchmarkDefer 1 0 -100.00% BenchmarkDefer10 1 0 -100.00% BenchmarkDeferMany 1 0 -100.00% benchmark old bytes new bytes delta BenchmarkDefer 64 0 -100.00% BenchmarkDefer10 64 0 -100.00% BenchmarkDeferMany 64 66 3.12% Fixes issue 2364.

Patch Set 1 #

Patch Set 2 : diff -r 1e5437c42bcc https://code.google.com/p/go/ #

Patch Set 3 : diff -r 536e2af64ab7 https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -39 lines)			Patch
M	src/pkg/runtime/cgocall.c	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/panic.c	View	1	9 chunks	+124 lines, -34 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2	4 chunks	+11 lines, -1 line	0 comments	Download
M	src/pkg/runtime/runtime_test.go	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 3 months ago (2012-12-22 19:54:34 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=91f2c8a77c8d *** runtime: aggregate defer allocations benchmark old ns/op new ns/op delta ...

12 years, 3 months ago (2012-12-22 19:54:41 UTC) #2

dave_cheney.net

Thank you. If I understand correctly, defer m.Unlock() just got a whole lot cheaper. On ...

12 years, 3 months ago (2012-12-22 22:40:24 UTC) #3

Message was sent while issue was closed.

lgtm

Expand All Messages | Collapse All Messages