Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1213)

Issue 69980047: code review 69980047: math/rand: speed up Float32, Float64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rsc
Modified:
10 years ago
Reviewers:
gobot, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

math/rand: speed up Float32, Float64 Actually, speed up Int31n and Int63n by avoiding retry loop. benchmark old ns/op new ns/op delta BenchmarkFloat32 32 26 -19.45% BenchmarkFloat64 46 23 -49.47% Fixes issue 7267.

Patch Set 1 #

Patch Set 2 : diff -r 7257b771f12b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2750cd9fc49b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/pkg/math/rand/rand.go View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/pkg/math/rand/rand_test.go View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8
rsc
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years ago (2014-03-03 21:00:24 UTC) #1
bradfitz
Isn't the tree closed? :-) On Mon, Mar 3, 2014 at 1:00 PM, <rsc@golang.org> wrote: ...
10 years ago (2014-03-03 21:06:35 UTC) #2
bradfitz
Oh, I see that this is a regression. You missed "Fixes Issue 7267" On Mon, ...
10 years ago (2014-03-03 21:17:50 UTC) #3
rsc
On Mon, Mar 3, 2014 at 4:17 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > Oh, I see ...
10 years ago (2014-03-04 00:54:21 UTC) #4
rsc
You're now the reviewer of record, Brad. :-)
10 years ago (2014-03-04 00:54:32 UTC) #5
bradfitz
LGTM On Mar 3, 2014 4:54 PM, "Russ Cox" <rsc@golang.org> wrote: > You're now the ...
10 years ago (2014-03-04 00:57:07 UTC) #6
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=361aac3d88a0 *** math/rand: speed up Float32, Float64 Actually, speed up Int31n and ...
10 years ago (2014-03-04 01:43:28 UTC) #7
gobot
10 years ago (2014-03-04 02:40:00 UTC) #8
Message was sent while issue was closed.
This CL appears to have broken the windows-386-ec2 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b