Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(892)

Issue 69870050: code review 69870050: path/filepath: ensure Glob does not ignore broken... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by hightower
Modified:
10 years ago
Reviewers:
gobot, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

path/filepath: ensure Glob does not ignore broken symlinks. Fixes issue 6463.

Patch Set 1 #

Patch Set 2 : diff -r d187b31342b5 https://code.google.com/p/go #

Patch Set 3 : diff -r d187b31342b5 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r d187b31342b5 https://code.google.com/p/go #

Patch Set 5 : diff -r d187b31342b5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M src/pkg/path/filepath/match.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/path/filepath/match_test.go View 1 2 3 2 chunks +53 lines, -1 line 0 comments Download

Messages

Total messages: 6
hightower
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years ago (2014-03-04 10:07:58 UTC) #1
bradfitz
Fix looks good. Few comments on the test. I've processed your CLA now. https://codereview.appspot.com/69870050/diff/40001/src/pkg/path/filepath/match_test.go File ...
10 years ago (2014-03-04 16:20:12 UTC) #2
hightower
Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years ago (2014-03-04 16:45:59 UTC) #3
bradfitz
LGTM
10 years ago (2014-03-04 17:00:37 UTC) #4
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=6614172310c7 *** path/filepath: ensure Glob does not ignore broken symlinks Fixes issue ...
10 years ago (2014-03-04 17:00:48 UTC) #5
gobot
10 years ago (2014-03-04 18:05:27 UTC) #6
This CL appears to have broken the linux-arm-cheney-panda builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b