Issue 69790046: code review 69790046: go-tour: removing unused javascript files from codemirr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69790046: code review 69790046: go-tour: removing unused javascript files from codemirr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by francesc

Modified:
10 years, 2 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

go-tour: removing unused javascript files from codemirror lib

Patch Set 1 #

Patch Set 2 : diff -r b65851ce9f0a https://code.google.com/p/go-tour #

Patch Set 3 : diff -r b65851ce9f0a https://code.google.com/p/go-tour #

Patch Set 4 : diff -r 457bfb9626df https://code.google.com/p/go-tour #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4327 lines)			Patch
R	static/lib/codemirror/addon/edit/closebrackets.js	View	1	1 chunk	+0 lines, -82 lines	0 comments	Download
R	static/lib/codemirror/addon/edit/closetag.js	View	1	1 chunk	+0 lines, -86 lines	0 comments	Download
R	static/lib/codemirror/addon/edit/continuelist.js	View	1	1 chunk	+0 lines, -25 lines	0 comments	Download
R	static/lib/codemirror/addon/edit/matchtags.js	View	1	1 chunk	+0 lines, -51 lines	0 comments	Download
R	static/lib/codemirror/keymap/emacs.js	View	1	1 chunk	+0 lines, -387 lines	0 comments	Download
R	static/lib/codemirror/keymap/extra.js	View	1	1 chunk	+0 lines, -43 lines	0 comments	Download
R	static/lib/codemirror/keymap/vim.js	View	1	1 chunk	+0 lines, -3653 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 2 months ago (2014-03-06 23:30:46 UTC) #1

francesc

10 years, 2 months ago (2014-03-06 23:37:01 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=5ba99ed727cc
***

go-tour: removing unused javascript files from codemirror lib

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/69790046

Expand All Messages | Collapse All Messages