Issue 69780044: code review 69780044: [release-branch.go1.2] net: ignore some errors in windo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69780044: code review 69780044: [release-branch.go1.2] net: ignore some errors in windo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by rsc

Modified:
10 years, 1 month ago

Reviewers:
r, gobot

CC:
golang-codereviews, r, golang-dev

Visibility:
Public.

Description

[release-branch.go1.2] net: ignore some errors in windows Accept ««« CL 49490043 / 7ecbc2b8ec97 net: ignore some errors in windows Accept Fixes issue 6987 R=golang-codereviews, dvyukov CC=golang-codereviews https://codereview.appspot.com/49490043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 87dea3f5ebe7 https://code.google.com/p/go #

Patch Set 3 : diff -r 2869b3245f8d https://code.google.com/p/go #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -8 lines)			Patch
M	src/pkg/net/fd_windows.go	View	1	3 chunks	+40 lines, -8 lines	0 comments	Download
A	src/pkg/net/net_windows_test.go	View	1	1 chunk	+146 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_windows.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 1 month ago (2014-02-28 01:46:52 UTC) #1

gobot

Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...

10 years, 1 month ago (2014-02-28 01:50:38 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=4e312b5239f0 *** [release-branch.go1.2] net: ignore some errors in windows Accept ««« CL ...

10 years, 1 month ago (2014-02-28 03:43:26 UTC) #4

gobot

10 years, 1 month ago (2014-02-28 05:31:52 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the windows-386-ec2 builder.

Expand All Messages | Collapse All Messages