Issue 6970048: code review 6970048: go.net/ipv4: change I/O method signatures on PacketConn...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6970048: code review 6970048: go.net/ipv4: change I/O method signatures on PacketConn... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by mikio

Modified:
12 years, 3 months ago

Reviewers:

CC:
dave_cheney.net, rsc, golang-dev

Visibility:
Public.

Description

go.net/ipv4: change I/O method signatures on PacketConn and RawConn Preserves both Read and Write signatures for the future usage.

Patch Set 1 #

Patch Set 2 : diff -r 903a863e059a https://code.google.com/p/go.net #

Patch Set 3 : diff -r 903a863e059a https://code.google.com/p/go.net #

Patch Set 4 : diff -r 3a318dc9be38 https://code.google.com/p/go.net #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
M	ipv4/example_test.go	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	ipv4/mocktransponder_test.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ipv4/packet.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ipv4/payload.go	View	1	2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

12 years, 3 months ago (2012-12-19 23:25:45 UTC) #1

mikio

12 years, 3 months ago (2012-12-20 22:30:49 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=2bfbe3ecae04&repo=net ***

go.net/ipv4: change I/O method signatures on PacketConn and RawConn

Preserves both Read and Write signatures for the future usage.

R=dave, rsc
CC=golang-dev
https://codereview.appspot.com/6970048

Expand All Messages | Collapse All Messages