code review 6949058: time: fix panic with time.Parse(time.StampNano, ... )

time: fix panic with time.Parse(time.StampNano, ... )

Fixes issue 4502.

[dfc, 2012-12-15 03:09:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-12-17 00:43:40]

https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go
File src/pkg/time/time_test.go (right):

https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go#ne...
src/pkg/time/time_test.go:637: {StampNano, "Dec  7 11:22:01.000000", "extra
text: .000000"},
This is not the right error. There is no extra text here, there are missing
digits.
http://play.golang.org/p/F7jmnR9VD6 (Go 1.0.3 I assume) says
 cannot parse ".000000" as ".000000000"
which I believe is the correct error.

[dfc, 2012-12-17 03:51:31]

Thank you for your feedback, please take another look.

https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go
File src/pkg/time/time_test.go (right):

https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go#ne...
src/pkg/time/time_test.go:637: {StampNano, "Dec  7 11:22:01.000000", "extra
text: .000000"},
On 2012/12/17 00:43:40, rsc wrote:
> This is not the right error. There is no extra text here, there are missing
> digits.
> http://play.golang.org/p/F7jmnR9VD6 (Go 1.0.3 I assume) says
>  cannot parse ".000000" as ".000000000"
> which I believe is the correct error.

Thank you, your version is correct. I have confirmed against 1.0.3 and adjusted
the test as appropriate.

[rsc, 2012-12-17 16:09:36]

LGTM

https://codereview.appspot.com/6949058/diff/1003/src/pkg/time/time_test.go
File src/pkg/time/time_test.go (right):

https://codereview.appspot.com/6949058/diff/1003/src/pkg/time/time_test.go#ne...
src/pkg/time/time_test.go:520: {"", "Jan _2 15:04:05.999", "Feb  4
21:00:57.012300000", false, false, -1, 4},
Please add a test case that is a copy of this one with 012345678 as the
fraction. It should work too.

[dfc, 2012-12-17 20:54:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=9a0e4777ea8b ***

time: fix panic with time.Parse(time.StampNano, ... )

Fixes issue 4502.

R=rsc
CC=golang-dev
https://codereview.appspot.com/6949058